Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"on" property incorrectly defined as a resource #25

Closed
cmhdave opened this issue Mar 14, 2019 · 2 comments
Closed

"on" property incorrectly defined as a resource #25

cmhdave opened this issue Mar 14, 2019 · 2 comments

Comments

@cmhdave
Copy link

cmhdave commented Mar 14, 2019

In the Annotation.java class the "on" variable is defined as a Resource. This renders an invalid presentation manifest. This is a correct manifest:
"on": "https://some.url/iiif/dcterms/672/canvas/c0"
whereas this code deserializes to
"on": { "@id": "https://some.url/iiif/vads-demo2/2/canvas/c0", "@type": "sc:Canvas" }
If you view the IIIF presentation specs, all the examples use the first example.

@morpheus-87
Copy link
Member

Could you please provide a complete example json? And how do you use the library?

@cmhdave
Copy link
Author

cmhdave commented Mar 15, 2019

Ah ha... I traced the code down a little more and see that when a Resource is created with Motivation.PAINTING the "on" property gets set correctly. I am going to close this issue since it works as designed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants