You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the URLs fed to the Twitter links in the CanvasLink and ImageCropper plugins may not appear correctly.
Because Twitter links are in the format https://twitter.com/intent?text=...&url=...&hashtags=..., any URL search parameters that occur after ampersands (I append &manifest= and &canvas= myself) will be disregarded. It probably wouldn't hurt to escape the ampersands (src/components/utils.js).
Same thing for Facebook and Pinterest, though I'm not sure about the Whatsapp and email links.
Edit: this is proving to be harder than I imagined. The nesting of a URL within a URL within a URL, mad as it sounds, is not necessarily the problem here, but I just don't know how to replace the ampersands in utils.js. Neither encodeURI() nor encodeURIComponent() is helpful. I tried percent-encoding to %26, which works when testing Twitter links directly, but somewhere along the way the percent symbol itself gets encoded to %25, so I ended up with %2526 rather than %26.
The text was updated successfully, but these errors were encountered:
I think I found a solution even though I'm wary of recommending it as a general one for everyone - I will leave that in your expert hands. What worked out for me, at least in the case of the Twitter, Facebook and Pinterest links, is the following:
Edit src/components/utils.js and replace {imageUrl} with encodeURIComponent({imageUrl})
Edit src/components/ShareButton.js and replace href: encodeURI(link) with plain href: link. (The double encoding I experienced above was of course due to encodeURI(). )
I noticed that the URLs fed to the Twitter links in the CanvasLink and ImageCropper plugins may not appear correctly.
Because Twitter links are in the format
https://twitter.com/intent?text=...&url=...&hashtags=...
, any URL search parameters that occur after ampersands (I append&manifest=
and&canvas=
myself) will be disregarded. It probably wouldn't hurt to escape the ampersands (src/components/utils.js
).Same thing for Facebook and Pinterest, though I'm not sure about the Whatsapp and email links.
Edit: this is proving to be harder than I imagined. The nesting of a URL within a URL within a URL, mad as it sounds, is not necessarily the problem here, but I just don't know how to replace the ampersands in utils.js. Neither encodeURI() nor encodeURIComponent() is helpful. I tried percent-encoding to
%26
, which works when testing Twitter links directly, but somewhere along the way the percent symbol itself gets encoded to%25
, so I ended up with%2526
rather than%26
.The text was updated successfully, but these errors were encountered: