This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
feature(themes): introduce dagbladet dark theme #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually just left-over code that's been lying around on my todo-list for about 8 months. It is not based on any sketches. It is not used anywhere. It is not complete.
Please adjust the settings as much as you'd like, it won't break anything, as nothing is using this theme for anything. This is just meant as a starting point.
The idea is to use all the variables and colors from the dagbladet theme, but then to remap just the skinColors. Didn't work out so well with the Type color, so I had to change it, but most of the palette should be just fine as it is. Fonts and other variables should probably not be affected.
Please tick a box
If you're adding a feature, is it documented in a storybook story?
Are the components you're working on reusable between brands?
If you're creating markup, did you add proper semantics?
(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)