Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies on hspec < 2.1 #7

Closed
jsantos17 opened this issue Feb 27, 2015 · 2 comments
Closed

Dependencies on hspec < 2.1 #7

jsantos17 opened this issue Feb 27, 2015 · 2 comments

Comments

@jsantos17
Copy link
Contributor

I just built it against 2.1.4 and all the tests pass. Am I missing something here? This restriction is preventing hspec-snap from working with Stackage.

@dbp
Copy link
Owner

dbp commented Feb 27, 2015

This package follows PVP (https://wiki.haskell.org/Package_versioning_policy), which means that there are always upper bounds, by default one minor version higher than the known / released version. Since according to the PVP, APIs are permitted to change with minor version bumps, this is a conservative policy that means that when dependencies can be satisfied, they should build. Of course, just because there can be breaking changes doesn't mean they necessarily affect all uses, which is what has happened here - the dependency should be < 2.2, not < 2.1.

Feel free to file a pull request updating the bound to < 2.2. If you don't want to, I'll try to update it myself soon, and regardless I'll release it as soon as that happens.

@dbp
Copy link
Owner

dbp commented Feb 27, 2015

This has been released to hackage as 0.3.2.3 - thanks!

@dbp dbp closed this as completed Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants