Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timezone warnings #28

Closed
wants to merge 2 commits into from

Conversation

hisaichi5518
Copy link

"DateTime" uses "time_zone". and "DBIx::Class::InflateColumn::DateTime" uses "timezone".
This becomes a trap. so I added a warning.

Sorry for the poor English.

@ribasushi
Copy link
Collaborator

Hi,

First of all thanks for submitting a pull request, it clearly solves a problem you encountered. However, I am having a hard time justifying inclusion of a single "typo"-warning into the main codebase. If you feel strongly that this needs to go in (and the performance penalty is worth it) - please attempt to generalize the code, so other misspellings can be easily added (some sort of project-global hash or whatnot). Also within DBIC carp() is more or less banned - you ought to use either carp_uniqe provided by DBIx::Class::Carp.

I will keep this PR open for couple weeks, and close it without further action if I do not hear back from you.

Cheers

@ribasushi
Copy link
Collaborator

Closing as per #28 (comment)

@ribasushi ribasushi closed this Sep 9, 2013
@ribasushi
Copy link
Collaborator

This keeps coming up, reopening and will integrate before next release.

@ribasushi
Copy link
Collaborator

This has now been properly addressed in eef9b48. Sorry it took a while

@ribasushi ribasushi closed this Jul 31, 2016
@hisaichi5518 hisaichi5518 deleted the add-timezone-warning branch August 1, 2016 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants