Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fixes #30

Closed
wants to merge 34 commits into from
Closed

typo fixes #30

wants to merge 34 commits into from

Conversation

dsteinbrunner
Copy link
Contributor

Looks like the github editor my have messed up lib/DBIx/Class/Storage/DBI/Replicated.pm in one spot...

@abraxxa
Copy link
Contributor

abraxxa commented Aug 8, 2013

Thanks for your great work!
Please combine them into a single commit in the future.
I've squashed and commited them to master already, someone else will close your pull-request.

@ribasushi
Copy link
Collaborator

Sorry for not replying earlier - as noted by @abraxxa things were already merged after squashing. I applied some extra fixes on top (f8213ab0 fixing the unicode/latin1 soup that you noticed in Replicated.pm and a4f0b0a restoring some spurious fixes)

I also very much appreciate the spellfixes, especially given you went over the comments as well (which are a major source of suck). However, I'd like to again urge you (like I did on IRC couple months ago) to translate your work into a tool that authors can use on their projects continuously. For instance the reason the DBIC project does not yet have a xt/spellcheck.t is because I want a solution that will parse/check comments as well. You seem to be using something like this in-house already. Please consider contributing it, CPAN will be forever grateful! ;)

Cheers and thanks for your work.

@ribasushi ribasushi closed this Aug 26, 2013
@karenetheridge
Copy link
Contributor

The common approach is Test::Spelling, but it doesn't (yet!) support comments.. I expect this could be added with a bit of PPI magic. so +1 from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants