Updates to examples #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes 'year' from the CD table definition in both the SQL and in the class definition, since it wasn't being used. The directory MyApp/Schema/ResultSet was also removed since the supplied code never used it. The results that the sample code produces have been expanded a little so that they provide answers to the questions asked by the subroutine calls. A new section has been added that briefly discusses the results and explains the techniques that could be used when writing this type of a programmatic query.
Some cleanup and simplification in the documentation.
This version just updates the original version with slightly more information so that more DBIx::Class functionality is revealed.
|
These three commits leave the structure of the examples complete, but delete the code from the POD. Instead the POD points the reader to the location of the code that inserts database into the DB and tests the results. |
|
Sorry for not paying enough attention - I somehow didn't realize the next commits add stuff (mistyped diff cmd on my end). I will review and merge #35 later tonight. Cheers! |
|
That's my bad for not cleaning up after myself. I should have done a better job making it clear. Let me know if you have any questions or feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the examples so that the example source code is referred to, but duplicated in the POD. In addition, the results in the examples have been expanded a little to better show off the functionality of the module.