Add test for update with literal bind for ARRAY #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dim0xff
changed the title
| @@ -116,7 +116,15 @@ sub _deflated_column { | |||
| my ($self, $col, $value) = @_; | |||
| # return $value unless ref $value && blessed($value); # If it's not an object, don't touch it | |||
| ## Leave scalar refs (ala SQL::Abstract literal SQL), untouched, deflate all other refs | |||
| return $value unless (ref $value && ref($value) ne 'SCALAR'); | |||
| ## Also leave ref refs if it is ARRAY | |||
| return $value | |||
There was a problem hiding this comment.
Probably the same changes should be here: https://github.com/dim0xff/dbix-class/blob/bug/literal_bind_inflate_on_update/lib/DBIx/Class/InflateColumn.pm#L193
|
This was addressed in a different way by 3705e3b2801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.