Preparation for 2.0 #93
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
===========================================
- Coverage 93.24% 92.78% -0.47%
===========================================
Files 17 17
Lines 311 291 -20
===========================================
- Hits 290 270 -20
Misses 21 21
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
===========================================
- Coverage 93.24% 92.78% -0.47%
===========================================
Files 17 17
Lines 311 291 -20
===========================================
- Hits 290 270 -20
Misses 21 21
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #93 +/- ##
===========================================
+ Coverage 93.59% 94.73% +1.13%
===========================================
Files 18 18
Lines 328 304 -24
===========================================
- Hits 307 288 -19
+ Misses 21 16 -5
Continue to review full report at Codecov.
|
…into feature/remove-deprecated-code # Conflicts: # DBNetworkStack.xcodeproj/project.pbxproj
| //Then | ||
| XCTAssertEqual(networkServiceMock.lastRequests, [resource.request, resource.request]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| //When | ||
| networkServiceMock.request(resource, onCompletion: { _ in }, onError: { _ in }) | ||
| networkServiceMock.request(resource, onCompletion: { _ in }, onError: { _ in }) | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| /// All executed requests. | ||
| public private(set) var lastRequests: [URLRequest] = [] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| public var lastRequest: URLRequest? { | ||
| return lastRequests.last | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| public var requestCount: Int { | ||
| return lastRequests.count | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -104,10 +97,20 @@ struct NetworkServiceMockCallback { | |||
| - seealso: `NetworkService` | |||
| */ | |||
| public final class NetworkServiceMock: NetworkService { | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
…into feature/remove-deprecated-code
Fixes issues:
URLRequestConvertibleNew feature:
Make sure to check all boxes before merging