Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Package.swift #97

Merged
merged 2 commits into from Oct 25, 2019
Merged

fixes Package.swift #97

merged 2 commits into from Oct 25, 2019

Conversation

lightsprint09
Copy link
Member

@lightsprint09 lightsprint09 commented Oct 25, 2019

Signed-off-by: Lukas Schmidt lukasschmidt@fastmail.com

Fixes issues:

New feature:

Make sure to check all boxes before merging

  • Method/Class documentation
  • README.md documentation
  • Unit tests for new features/regressions

Signed-off-by: Lukas Schmidt <lukasschmidt@fastmail.com>
Signed-off-by: Lukas Schmidt <lukasschmidt@fastmail.com>
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #97 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    94.73%   94.76%   +0.02%     
===========================================
  Files           18       35      +17     
  Lines          304     1298     +994     
===========================================
+ Hits           288     1230     +942     
- Misses          16       68      +52
Impacted Files Coverage Δ
...s/DBNetworkStackTests/NetworkServiceMockTest.swift 98.27% <0%> (ø)
...tworkStackTests/URLSession+NetworkAccessTest.swift 100% <0%> (ø)
...sts/DBNetworkStackTests/NetworkTaskMockTests.swift 100% <0%> (ø)
Tests/DBNetworkStackTests/NetworkErrorTest.swift 97.6% <0%> (ø)
.../DBNetworkStackTests/RetryNetworkserviceTest.swift 85.41% <0%> (ø)
...tworkStackTests/NetworkResponseProcessorTest.swift 78.12% <0%> (ø)
Tests/DBNetworkStackTests/NetworkAccessMock.swift 100% <0%> (ø)
...sts/DBNetworkStackTests/DecodableResoureTest.swift 100% <0%> (ø)
Tests/DBNetworkStackTests/NetworkServiceTest.swift 92.04% <0%> (ø)
Tests/DBNetworkStackTests/ResourceTest.swift 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca1533...1280193. Read the comment docs.

@lightsprint09 lightsprint09 merged commit d69f876 into develop Oct 25, 2019
@lightsprint09 lightsprint09 deleted the fix-spm branch September 6, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant