Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hive-style quote impl leaks into libs that use dbt-athena #277

Closed
brabster opened this issue May 3, 2023 · 2 comments
Closed

New hive-style quote impl leaks into libs that use dbt-athena #277

brabster opened this issue May 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@brabster
Copy link
Contributor

brabster commented May 3, 2023

I've been trying to sort out a PR to enable external table support for Athena over in dbt-external-tables. I've hit a minor-ish problem in that I've had to use the new render_hive() function to get the quoting right on these DDL statements. (relevant commit)

That does work but it does make supporting versions of dbt-athena prior to 1.4.1 tricky - I've just not bothered for now - but it also suggests a potentially troublesome bit of coupling. I'm no dbt expert so maybe there's a better way of getting the right quoting for these statements?

@nicor88 nicor88 added the bug Something isn't working label May 8, 2023
@sacundim
Copy link

This looks related to my ticket: #182

@nicor88
Copy link
Member

nicor88 commented Oct 9, 2023

Let's use #182 instead, that seems more descriptive.

@nicor88 nicor88 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants