Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different table creation strategies for Iceberg #64

Closed
Jrmyy opened this issue Nov 25, 2022 · 2 comments
Closed

Different table creation strategies for Iceberg #64

Jrmyy opened this issue Nov 25, 2022 · 2 comments
Assignees
@Jrmyy
Labels
iceberg This issue concerns Iceberg integration

Comments

@Jrmyy
Copy link
Member

Jrmyy commented Nov 25, 2022 •
edited

Athena engine v3 supports CTAS for Iceberg.

Since engine v2 does not support that, what about adding a table_strategy in the table materialization with the following alternatives : tmp_table and ctas.

  • ctas is by default for all non iceberg tables and the only possibility.
  • tmp_table must be set for engine v2 for Iceberg tables.
  • ctas or tmp_table can be chosen for engine v3 for Iceberg tables.

What do you think ?
@nicor88
Copy link
Member

nicor88 commented Nov 25, 2022

Nice idea, I like it, so by default our ctas

@Jrmyy Jrmyy added enhancement iceberg This issue concerns Iceberg integration labels Nov 29, 2022
@Jrmyy Jrmyy self-assigned this Nov 30, 2022
@Jrmyy Jrmyy mentioned this issue Dec 1, 2022
Closed
3 tasks
@Jrmyy
Copy link
Member Author

Jrmyy commented Dec 5, 2022

#74 (comment)

Meaning everything will be created using CTAS.

@Jrmyy Jrmyy closed this as completed Dec 5, 2022
@Jrmyy Jrmyy mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jrmyy Jrmyy

Labels
iceberg This issue concerns Iceberg integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: iceberg ctas dbt-athena/dbt-athena
2 participants
@nicor88 @Jrmyy