Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tests leaving behind schemas #128

Open
2 tasks done
benc-db opened this issue Mar 11, 2024 · 0 comments
Open
2 tasks done

[Bug] Tests leaving behind schemas #128

benc-db opened this issue Mar 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@benc-db
Copy link

benc-db commented Mar 11, 2024

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

@mikealfare asked me to file this bug. I've seen a small number of functional tests leaving behind schemas/tables, typically because they create a schema that is not enumerated in the manifest. In particular, I have seen the following tests do this without significant modification for my adapter:

  • BaseSameAliasDifferentSchemas
  • BaseSameAliasDifferentDatabases

I have also seen the following tests have this issue, but I'm much less confident it wasn't related to a change that I had to make for Databricks:

  • dbt_debug - test_ok
  • dbt_clone - test_clone_same_target_and_state

Note: I'm hitting this in 1.7.x, so nothing specific to the adapter decoupling effort, but was asked to file here.

Expected Behavior

All tests clean up all schemas when they're done

Steps To Reproduce

Run the specified tests.

Relevant log output

No response

Environment

No response

Additional Context

No response

@benc-db benc-db added bug Something isn't working triage labels Mar 11, 2024
@mikealfare mikealfare removed the triage label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants