Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Linting/pre-commit check on dbt-core as a dependency #144

Closed
3 tasks done
colin-rogers-dbt opened this issue Apr 3, 2024 · 0 comments · Fixed by #174, dbt-labs/dbt-postgres#62, #177, dbt-labs/dbt-snowflake#981 or dbt-labs/dbt-bigquery#1188
Assignees
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-adapter functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As we have decided not to remove dbt-core as an install requirement for adapters we need a check to prevent it from being re-introduced as a code dependency.
To do so we should add a pre-commit check that all implementing adapters can reference in dbt-adapters. This check would parse the imports and raise an error if dbt-core is imported.
https://pre-commit.com/#new-hooks

Describe alternatives you've considered

Unit/Functional test - decided against this as this isn't really a code "test" but a check similar to what a linter like mypy would do.

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@colin-rogers-dbt colin-rogers-dbt added enhancement New feature or request triage and removed triage labels Apr 3, 2024
@mikealfare mikealfare linked a pull request Apr 19, 2024 that will close this issue
4 tasks
@mikealfare mikealfare linked a pull request Apr 19, 2024 that will close this issue
4 tasks
@mikealfare mikealfare linked a pull request Apr 19, 2024 that will close this issue
4 tasks
@mikealfare mikealfare linked a pull request Apr 19, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment