Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-847] [Bug] references to deprecated __TABLES__ metadata table #897

Closed
2 tasks done
sambloom92 opened this issue Aug 24, 2023 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@sambloom92
Copy link

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

I noticed when running dbt docs generate that the BigQuery adapter is querying project.dataset.__TABLES__ in order to build the catalog. This metadata table was deprecated in May 2021 and was replaced with INFORMATION_SCHEMA.TABLES documented here. I am unaware of any potential impacts this may have, but I think it would be prudent to update this before any impacts might arise.

Expected Behavior

I would expect the BigQuery adapter to have removed references to the __TABLES__ metadata table and replaced them with INFORMATION_SCHEMA.TABLES

Steps To Reproduce

A quick search of this repository reveals several uses of __TABLES__ but no uses of INFORMATION_SCHEMA.TABLES

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response

@sambloom92 sambloom92 added bug Something isn't working triage labels Aug 24, 2023
@github-actions github-actions bot changed the title [Bug] references to deprecated __TABLES__ metadata table [ADAP-847] [Bug] references to deprecated __TABLES__ metadata table Aug 24, 2023
@dbeatty10
Copy link
Contributor

Thanks for raising this @sambloom92 🧠

#113 had been closed after going stale, but I just re-opened it.

#364 has a draft implementation. It needs some more work around figuring out how to handle row_count or size_bytes which are present in project.dataset.__TABLES__ but not in project.dataset.INFORMATION_SCHEMA.TABLES.

I'm going to close this issue as a duplicate of #113, but we'd love to have you subscribe and participate in that issue and the corresponding PR to the extent you are interested.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants