Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh syntax, config comparison with empty labels #983

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Fix refresh syntax, config comparison with empty labels #983

merged 7 commits into from
Oct 27, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 26, 2023 •
edited

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 26, 2023
@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare changed the title Fix autorefresh bugs Fix refresh syntax, config comparison with empty labels Oct 26, 2023
@mikealfare mikealfare marked this pull request as ready for review October 26, 2023 17:48
@mikealfare mikealfare requested a review from a team as a code owner October 26, 2023 17:48
@mikealfare mikealfare merged commit f139e95 into main Oct 27, 2023
12 checks passed
@mikealfare mikealfare deleted the bug/materialized-views/auto-refresh branch October 27, 2023 21:01
@mikealfare mikealfare added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Oct 27, 2023
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
@mikealfare @github-actions
Fix refresh syntax, config comparison with empty labels (#983)
4b40723 
* map an empty labels dict to none for comparison

* remove drop statement that isn't used

* fix refresh statement

* add drop materialized view back, it gets called by replace

* changelog

(cherry picked from commit f139e95)
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
colin-rogers-dbt pushed a commit that referenced this pull request Oct 28, 2023
@github-actions @mikealfare
Fix refresh syntax, config comparison with empty labels (#983) (#990)
381b859 
* map an empty labels dict to none for comparison

* remove drop statement that isn't used

* fix refresh statement

* add drop materialized view back, it gets called by replace

* changelog

(cherry picked from commit f139e95)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikealfare @colin-rogers-dbt