Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SECRET_ENV_PREFIX from dbt_common instead of dbt_core #10018

Closed
1 task done
emmyoop opened this issue Apr 23, 2024 · 0 comments · Fixed by #10019
Closed
1 task done

Use SECRET_ENV_PREFIX from dbt_common instead of dbt_core #10018

emmyoop opened this issue Apr 23, 2024 · 0 comments · Fixed by #10019
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 23, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

We duplicate teh expected value of SECRET_ENV_PREFIX in dbt-core and dbt-common. We should stop.

Acceptance criteria

SECRET_ENV_PREFIX is not defined in dbt-core and only imported by dbt-common

Suggested Tests

existing tests need to be updated, no additional tests needed

Impact to Other Teams

None

Will backports be required?

No

Context

Defining this constant in 2 places creates risk that it will get out of sync.

@emmyoop emmyoop added the user docs [docs.getdbt.com] Needs better documentation label Apr 23, 2024
@emmyoop emmyoop removed the user docs [docs.getdbt.com] Needs better documentation label Apr 24, 2024
@emmyoop emmyoop self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant