-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if timestamp updated_at field uses incompatible timestamp #10352
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10352 +/- ##
==========================================
- Coverage 88.75% 88.74% -0.02%
==========================================
Files 180 180
Lines 22486 22497 +11
==========================================
+ Hits 19958 19964 +6
- Misses 2528 2533 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
time: 2024-06-21T16:44:00.023992-04:00 | ||
custom: | ||
Author: gshank | ||
Issue: "10234" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: are two changelog entries intentional?
resolves #10234
Problem
Snapshot tables use the 'get_snapshot_time' macro, which may be incompatible with the data type of the field specified as the 'updated_at' field, causing unexpected results.
Solution
Warn if the two sources of timestamp columns have different data types.
Checklist