adapters w/o boolean support can't use 'check' strategy on snapshots with new columns

[dataders]

I'm surprised no dbt-sql server user ever reports this issue before, but this TRUE causes problems for SQL dialects that don't support boolean types. related: dbt-msft/dbt-sqlserver#186 thanks to @oscar-konig for making a reproducible example that led to this fix!

Rather than asking adapter maintainers to override snapshot_check_strategy, a better answer would be a simple macro for generating a boolean expression with the default of course being TRUE, but in non-core adapters, it could be 1=1

dbt-core/core/dbt/include/global_project/macros/materializations/snapshots/strategies.sql

Lines 157 to 174 in 0ed14fa

	{%- set row_changed_expr -%}
	(
	{%- if column_added -%}
	TRUE
	{%- else -%}
	{%- for col in check_cols -%}
	{{ snapshotted_rel }}.{{ col }} != {{ current_rel }}.{{ col }}
	or
	(
	(({{ snapshotted_rel }}.{{ col }} is null) and not ({{ current_rel }}.{{ col }} is null))
	or
	((not {{ snapshotted_rel }}.{{ col }} is null) and ({{ current_rel }}.{{ col }} is null))
	)
	{%- if not loop.last %} or {% endif -%}
	{%- endfor -%}
	{%- endif -%}
	)
	{%- endset %}

[McKnight-42]

@dataders tracking your work on the PR, thank you so much for pointing this out, please let me know if there is anything I can do to help.

[McKnight-42]

Thank you @dataders for all the work you put in on this closing this issue as it was pushed up via #4871