Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-702] [Bug] Duplicate dbt script entry #5314

Closed
1 task done
groodt opened this issue May 31, 2022 · 1 comment · Fixed by #5304
Closed
1 task done

[CT-702] [Bug] Duplicate dbt script entry #5314

groodt opened this issue May 31, 2022 · 1 comment · Fixed by #5304
Labels
bug Something isn't working install

Comments

@groodt
Copy link
Contributor

groodt commented May 31, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

There is a duplicate dbt script entry in setup.py

When installing the wheel, the console_script is overwriting the hand-written code in scripts/dbt. pip should not be overwriting files during installation and will begin to log warnings at some point in future. See: pypa/pip#4625 (comment)

You can confirm this by installing dbt-core into a venv. The contents of the dbt script is an autogenerated console_script defined in entry_points and not the handwritten script.

Expected Behavior

There should only be a single script (probably the entry_point console script) which is currently the one that is installed.

Steps To Reproduce

No response

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

What database are you using dbt with?

No response

Additional Context

See #5304

@groodt groodt added bug Something isn't working triage labels May 31, 2022
@github-actions github-actions bot changed the title [Bug] Duplicate dbt script entry [CT-702] [Bug] Duplicate dbt script entry May 31, 2022
@stu-k
Copy link
Contributor

stu-k commented Jun 7, 2022

@groodt Thank you for pointing this out, and creating an associated PR! I have been following along on the PR side, and will close this issue once that work is merged 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working install
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants