[CT-737] [Bug] Wonky pluralization when duplicate docs are found

[pdebelak]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

The error message for duplicate docs is:

dbt found two docss with the name "whatever".

Expected Behavior

The error message would be:

dbt found two docs with the name "whatever".

Steps To Reproduce

1. Create multiple {% docs whatever %} blocks with the same name.
2. Run dbt parse.
3. See the weird pluralization in the output.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

What database are you using dbt with?

redshift

Additional Context

I believe the pluralize method of NodeType.Documentation would need to be updated to change this.

[jtcohen6]

@pdebelak Nice catch!

I believe the pluralize method of NodeType.Documentation would need to be updated to change this.

You're spot on :) Would you like to contribute the fix for this?

dbt-core/core/dbt/node_types.py

Lines 57 to 61 in 72b6a80

	def pluralize(self) -> str:
	if self == "analysis":
	return "analyses"
	else:
	return f"{self}s"

Is the plural of docs, docs? Should it be docs blocks (per our docs)? I could go either way.