Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1514] [Feature] Finalize and Merge Binary Logging #6268

Closed
3 tasks done
peterallenwebb opened this issue Nov 16, 2022 · 2 comments
Closed
3 tasks done

[CT-1514] [Feature] Finalize and Merge Binary Logging #6268

peterallenwebb opened this issue Nov 16, 2022 · 2 comments
Labels
enhancement New feature or request logging stale Issues that have gone stale

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Nov 16, 2022

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We created a binary structured-logging prototype in branch for issue #6138 and are now ready to incorporate feedback and merge the branch. In order to complete the work, we will:

  • Encode event blocks using Consistent Overhead Byte Stuffing. This will provide the ability to recover from errors in the event stream, make it easier to document the format, and allow downstream consumers to use standard protobuf and COBS libraries for processing.
  • Work with Gerda to finalize message modeling in protobuf, preferring to use a single message type to frame more specific messages, so that we can use the simplest format possible and guarantee binary format stability in the future.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@peterallenwebb peterallenwebb added enhancement New feature or request triage labels Nov 16, 2022
@github-actions github-actions bot changed the title [Feature] Finalize and Merge Binary Logging [CT-1514] [Feature] Finalize and Merge Binary Logging Nov 16, 2022
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label May 16, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logging stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

1 participant