Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1534] Remove EVENT_HISTORY from new logger #6288

Closed
gshank opened this issue Nov 18, 2022 · 1 comment · Fixed by #6291
Closed

[CT-1534] Remove EVENT_HISTORY from new logger #6288

gshank opened this issue Nov 18, 2022 · 1 comment · Fixed by #6291
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone
v1.4

Comments

@gshank
Copy link
Contributor

gshank commented Nov 18, 2022

The previous implementation of event history did not actually contain important attributes for the log. Containing python objects in a large in-memory deque is a bad idea because anything to which the events hold references will not be garbage collected, leading to memory issues. In addition this particular log output method will be superceded by new code.

Remove the EVENT_HISTORY and related flag and code.
@github-actions github-actions bot changed the title Remove EVENT_HISTORY from new logger [CT-1534] Remove EVENT_HISTORY from new logger Nov 18, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 6, 2022

This is being removed in #6291

@jtcohen6 jtcohen6 linked a pull request Dec 6, 2022 that will close this issue
CT-1405: Refactor event logging code #6291
Merged
6 tasks
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language logging labels Dec 6, 2022
@jtcohen6 jtcohen6 added this to the v1.4 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

CT-1405: Refactor event logging code dbt-labs/dbt-core
2 participants
@gshank @jtcohen6