Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1718] Add an "FYI" Message Type #6481

Closed
peterallenwebb opened this issue Dec 22, 2022 · 2 comments · Fixed by #6691
Closed

[CT-1718] Add an "FYI" Message Type #6481

peterallenwebb opened this issue Dec 22, 2022 · 2 comments · Fixed by #6691
Assignees
Labels
enhancement New feature or request logging
Milestone

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Dec 22, 2022

Describe the feature

Sometimes we have messages we would would like to write to the console without creating a custom event type. For example, we often want to add formatting by inserting blank lines or break lines like "=====...". We also have a variety of messages we print for informational purposes, but which are unlikely to be consumed programmatically by structured logging users.

To solve this problem, let's introduce a new event type which contains the standard event fields, but only one additional field (called "Text" or "Message"?) which can include miscellaneous text and formatting.

After this change, we should also be able to remove the EmptyLine event.

Who will this benefit?

Consumers of structured logging will benefit from this change, since they will no longer see events like EmptyLine which are useless to them. Since this change will also make it possible to remove other events, like StarterProjectPath and project initialization related events, it will reduce the complexity and size of our event schema.

@github-actions github-actions bot changed the title Add an "FYI" Message Type [CT-1718] Add an "FYI" Message Type Dec 22, 2022
@jtcohen6 jtcohen6 added this to the v1.4 milestone Jan 11, 2023
@jtcohen6
Copy link
Contributor

resolved by #6561

@jtcohen6
Copy link
Contributor

Sorry! This was not included in #6561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants