Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1745] Reword deprecation message for metric attribute rename #6507

Closed
jtcohen6 opened this issue Jan 4, 2023 · 2 comments · Fixed by #6518
Closed

[CT-1745] Reword deprecation message for metric attribute rename #6507

jtcohen6 opened this issue Jan 4, 2023 · 2 comments · Fixed by #6518
Assignees
@callum-mcdata
Labels
enhancement New feature or request semantic Issues related to the semantic layer
Milestone
v1.4

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 4, 2023

After discussion with @callum-mcdata, let's pause on removing the deprecation warning & backwards compatibility for now, given greater changes that we're envisioning for the metrics spec in the next few versions (e.g. #6379).

In the meantime, let's just update the deprecation warning to replace "in v1.4" with "in a future version":

dbt-core/core/dbt/events/types.py

Line 395 in fafd5ed

"\nThe old metric parameter names will be fully deprecated in v1.4."

Originally posted by @jtcohen6 in #5849 (comment)
@jtcohen6 jtcohen6 added this to the v1.4 milestone Jan 4, 2023
@github-actions github-actions bot changed the title Reword deprecation message for metric attribute rename [CT-1745] Reword deprecation message for metric attribute rename Jan 4, 2023
@jtcohen6 jtcohen6 added the enhancement New feature or request label Jan 4, 2023
@jtcohen6 jtcohen6 self-assigned this Jan 4, 2023
@callum-mcdata
Copy link
Contributor

@jtcohen6 want me to handle updating the message? I had it on my to-do list for today but if you've got a handle on it I'm happy to step back!

@jtcohen6 jtcohen6 assigned callum-mcdata and unassigned jtcohen6 Jan 4, 2023
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 4, 2023

@callum-mcdata all yours! (& thank you!)

@callum-mcdata callum-mcdata mentioned this issue Jan 4, 2023
Merged
6 tasks
@callum-mcdata callum-mcdata mentioned this issue Jan 6, 2023
Closed
4 tasks
@jtcohen6 jtcohen6 added the semantic Issues related to the semantic layer label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callum-mcdata callum-mcdata

Labels
enhancement New feature or request semantic Issues related to the semantic layer
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Updating metric attributes renamed event dbt-labs/dbt-core
2 participants
@jtcohen6 @callum-mcdata