Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2265] [Feature] Allow adapters to overwrite python model name resolution #7114

Closed
3 tasks done
colin-rogers-dbt opened this issue Mar 3, 2023 · 1 comment · Fixed by #7115
Closed
3 tasks done

[CT-2265] [Feature] Allow adapters to overwrite python model name resolution #7114

colin-rogers-dbt opened this issue Mar 3, 2023 · 1 comment · Fixed by #7115
Labels
enhancement New feature or request python_models Team:Adapters Issues designated for the adapter area of the code

Comments

@colin-rogers-dbt
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We've realized, as part of this change, that there is an opportunity to clean up our code and allow adapters (in this case dbt-bigquery) to have a different method in handling quoting in python models

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@colin-rogers-dbt colin-rogers-dbt added enhancement New feature or request triage labels Mar 3, 2023
@github-actions github-actions bot changed the title [Feature] Allow adapters to overwrite python model name resolution [CT-2265] [Feature] Allow adapters to overwrite python model name resolution Mar 3, 2023
@colin-rogers-dbt colin-rogers-dbt mentioned this issue Mar 3, 2023
Merged
6 tasks
@jtcohen6
Copy link
Contributor

jtcohen6 commented Mar 3, 2023 •
edited

Thanks @colin-rogers-dbt! Attempted to summarize our huddle in this comment: #6620 (comment)

@jtcohen6 jtcohen6 added Team:Adapters Issues designated for the adapter area of the code python_models and removed triage labels Mar 3, 2023
@colin-rogers-dbt colin-rogers-dbt mentioned this issue Mar 3, 2023
Merged
6 tasks
@chamini2 chamini2 mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request python_models Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to allow adapters to change model name resolution in py models dbt-labs/dbt-core
2 participants
@jtcohen6 @colin-rogers-dbt