Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2483] Use depends_on.add_node instead of depends_on.nodes.append #7453

Closed
gshank opened this issue Apr 24, 2023 · 1 comment · Fixed by #7455
Closed

[CT-2483] Use depends_on.add_node instead of depends_on.nodes.append #7453

gshank opened this issue Apr 24, 2023 · 1 comment · Fixed by #7455
Assignees
@gshank
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@gshank
Copy link
Contributor

gshank commented Apr 24, 2023 •
edited

In some circumstances we end up with multiple duplicated unique_ids in depends_on.nodes. Switch to using "add_node" instead of append so that duplicates are avoided. Fix the artifacts tests...

The place that needs to be fixed is in core/dbt/parser/manifest.py at the end of "_process_refs_for_node"
@github-actions github-actions bot changed the title Use depends_on.add_node instead of depends_on.nodes.append [CT-2483] Use depends_on.add_node instead of depends_on.nodes.append Apr 24, 2023
@gshank gshank self-assigned this Apr 24, 2023
@gshank gshank mentioned this issue Apr 24, 2023
Merged
6 tasks
@jtcohen6
Copy link
Contributor

Ooh! Might this also fix #5877?

@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CT 2483 duplicate depends on nodes dbt-labs/dbt-core
2 participants
@gshank @jtcohen6