Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2517] Graph selection for public models from dependency projects #7496

Closed
Tracked by #7372
MichelleArk opened this issue May 3, 2023 · 1 comment · Fixed by #7891
Closed
Tracked by #7372

[CT-2517] Graph selection for public models from dependency projects #7496

MichelleArk opened this issue May 3, 2023 · 1 comment · Fixed by #7891
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented May 3, 2023

Currently dbt ls does not include any models from publication artifacts (dependency projects). Should it? My inclination would be to output public model dependencies the same way that models from installed packages output.

E.g, a project with project_a.public_model available s a dependency:

❯ dbt ls
14:43:02  Running with dbt=1.6.0-a1
14:43:02  target not specified in profile 'postgres', using 'default'
14:43:02  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 307 macros, 0 operations, 0 seed files, 2 sources, 0 exposures, 0 metrics, 0 groups
consumer_project.cross_project_ref
consumer_project.model
source:consumer_project.jaffle_shop.customers
source:consumer_project.jaffle_shop.orders
@github-actions github-actions bot changed the title Graph selection for public models from dependency projects [CT-2517] Graph selection for public models from dependency projects May 3, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented May 26, 2023

dbt ls should include upstream public models.

Let's make sure the JSON output of dbt ls has some sort of attribute to distinguish this as an upstream public model. (It will have the package_name which differs from the current project name, but wouldn't necessarily distinguish it from models from packages / installed as source code.)

For dbt ls with text output, this will just look like:

upstream_project.public_model

@jtcohen6 jtcohen6 removed the Refinement Maintainer input needed label May 26, 2023
@jtcohen6 jtcohen6 removed their assignment May 26, 2023
@gshank gshank assigned gshank and unassigned MichelleArk Jun 5, 2023
@leahwicz leahwicz assigned MichelleArk and unassigned gshank Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants