Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2668] Improve ref() Parsing for SemanticModel Objects #7822

Closed
Tracked by #7498
peterallenwebb opened this issue Jun 7, 2023 · 0 comments · Fixed by #7895
Closed
Tracked by #7498

[CT-2668] Improve ref() Parsing for SemanticModel Objects #7822

peterallenwebb opened this issue Jun 7, 2023 · 0 comments · Fixed by #7895
Assignees

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Jun 7, 2023

As observed during review of our SemanticModels work, there are a couple important improvements which could be made to the way we are parsing the ref() expressions in SemanticModel.

  • We should catch internal parsing exceptions and raise a more informative one.
  • We should raise an exception if the ref does not resolve to a model.
  • We should consider resolving refs at parse time, rather than deferring until the entire manifest is (almost) ready.
  • We should check whether the ref'd model is disabled, and raise a specific exception if it is not.
@github-actions github-actions bot changed the title Improve ref() Parsing for SemanticModel Objects [CT-2668] Improve ref() Parsing for SemanticModel Objects Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants