Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2827] TestSingularTestsEphemeralSnowflake::test_singular_tests_ephemeral is flaky #8103

Closed
Tracked by #7808
mikealfare opened this issue Jul 17, 2023 · 4 comments

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Jul 17, 2023

Different status types come through the test. It's not always clear which one. The test fails when trying to assert a positive status. When it gets the correct status class (RunStatus I believe), it passes, because the value is pass. But when it gets he wrong one (TestStatus I believe), then it fails; I think this happens because the positive status on that is success, hence pass becomes fail since it's not a valid value.

@github-actions github-actions bot changed the title TestSingularTestsEphemeralSnowflake::test_singular_tests_ephemeral is flaky [CT-2827] TestSingularTestsEphemeralSnowflake::test_singular_tests_ephemeral is flaky Jul 17, 2023
@MichelleArk
Copy link
Contributor

This test is also flaky in the base core implementation: TestSingularTestsEphemeral.test_singular_tests_ephemeral

https://github.com/dbt-labs/dbt-core/actions/runs/5583460196/jobs/10203801831?pr=6346

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 18, 2023

I believe this is the test that's been flaky since the upgrade to sqlparse==0.4.4. It only fails on Ubuntu. This is what motivated us to pin sqlparse<0.4.4 previously:

It was also reported in the wild by a handful of users:

We weren't able to identify root cause, nor were we able to rip out sqlparse and replace it with something more naive.

@aosingh
Copy link

aosingh commented Jul 20, 2023

As a temporary workaround for all testcases to pass in our Github Actions CI pipeline, I reinstall sqlparse==0.4.3

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 2, 2023

Pretty sure this should be fixed by #8215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants