Update typing-extensions version to >=4.4 #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9012 +/- ##
==========================================
- Coverage 86.50% 86.46% -0.05%
==========================================
Files 179 179
Lines 26508 26508
==========================================
- Hits 22932 22920 -12
- Misses 3576 3588 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
With the addition of dbt-semantic-interfaces as a package dependency for dbt-core we added an implicit requirement that the local install of typing-extensions be for a version >= 4.4. This means, effective with dbt-core 1.6, our version minimum for typing-extensions has been updated to 4.4. This change reflects the reality imposed on us by our dependency hierarchy. Happily, mashumaro previously boosted its base version dependency to 4.1 some time ago, and effective with major version 4 the typing-extensions package maintainers have committed to strictly following SemVer, so this should be a low risk minimum version change.
tlento
force-pushed
the
update-typing-extensions-bound
branch
from
fd8a28c
to
e8242cc
Compare
|
Note - we may choose to backport this to 1.6 and 1.7, but it's not necessary, as all new installs of 1.6 and 1.7 will naturally pick up the changes from dbt-semantic-interfaces. |
MichelleArk
approved these changes
Nov 8, 2023
jtcohen6
reviewed
Nov 8, 2023
| @@ -73,7 +73,6 @@ | |||
| # These are major-version-0 packages also maintained by dbt-labs. Accept patches. | |||
| "dbt-extractor~=0.5.0", | |||
| "minimal-snowplow-tracker~=0.0.2", | |||
| # DSI is under active development, so we're pinning to specific dev versions for now. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7828
Problem
With the addition of dbt-semantic-interfaces as a package dependency
for dbt-core we added an implicit requirement that the local install
of typing-extensions be for a version >= 4.4. This means, effective
with dbt-core 1.6, our version minimum for typing-extensions has been
updated to 4.4.
This caused issues in certain install environments due to virtual envs with
pre-installs of out of date packages. While that has been addressed with
a patch update of dbt-semantic-interfaces, we should still have the correct
dependencies listed in dbt-core as well.
Solution
The solution is to just update the verison.
This change reflects the reality imposed on us by our dependency hierarchy.
Happily, mashumaro previously boosted its base version dependency to 4.1
some time ago, and effective with major version 4 the typing-extensions
package maintainers have committed to strictly following SemVer, so this
should be a low risk minimum version change.
Checklist