Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom _error_tag and use error_tag provided by dbt-common #9914

Closed
1 task done
QMalcolm opened this issue Apr 12, 2024 · 0 comments · Fixed by #9927
Closed
1 task done

Drop custom _error_tag and use error_tag provided by dbt-common #9914

QMalcolm opened this issue Apr 12, 2024 · 0 comments · Fixed by #9927
Assignees
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

In #9886 we added a stop gap _error_tag to core which really should belong in dbt-common. Closing dbt-labs/dbt-common#107 will mean it exists in dbt-common. Once dbt-common releases that feature, we should migrate to using that and drop the custom implementation in core.

Acceptance criteria

  • _error_tag implementation in core is delete
  • things using core's _error_tag use dbt-common's error_tag

Suggested Tests

N/A

Impact to Other Teams

N/A

Will backports be required?

N/A

Context

No response

@QMalcolm QMalcolm added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Apr 12, 2024
@QMalcolm QMalcolm self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant