Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update agate version #9934

Closed
3 tasks done
mjkanji opened this issue Apr 15, 2024 · 2 comments · Fixed by #9948 or dbt-labs/dbt-common#119
Closed
3 tasks done

[Feature] Update agate version #9934

mjkanji opened this issue Apr 15, 2024 · 2 comments · Fixed by #9948 or dbt-labs/dbt-common#119
Labels
dependencies Changes to the version of dbt dependencies enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@mjkanji
Copy link
Contributor

mjkanji commented Apr 15, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Agate is currently pinned to agate>=1.7.0,<1.8". If it doesn't raise breaking changes, can the version be increased to the latest version of agate (currently 1.9.1).

Installing the latest version of dbt-core using conda-forge on osx-arm64 was previously not possible because there was no support for agate. The feedstock for agate has now been updated with a noarch package for the latest version (1.9.1), but none of the available candidates on conda-forge match the current pin (agate>=1.7.0,<1.8"). As a result, I still can't install dbt-core using conda-forge.

Describe alternatives you've considered

N/A

Who will this benefit?

Anyone trying to install dbt-core via conda-forge.

Are you interested in contributing this feature?

If it's a simple change to the pin and running some tests, I can do that.

Anything else?

No response

@mjkanji mjkanji added enhancement New feature or request triage labels Apr 15, 2024
@dbeatty10 dbeatty10 self-assigned this Apr 15, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @mjkanji !

As noted in #7368, we put an upper bound on agate out of an abundance of caution because there have been breaking changes in past patch/minor versions.

The easiest solution would be if conda-forge/agate-feedstock#21 is resolved by including the relevant versions of agate.

But we'd also be willing to look at raising the upper bound so that it includes these more recent versions of agate available on PyPI:

  • 1.9.1 Dec 21, 2023
  • 1.9.0 Oct 17, 2023
  • 1.8.0 Oct 10, 2023

If it's a simple change to the pin and running some tests, I can do that.

Yep, to the best of my knowledge, that's what it would involve so I'm going to label this as a good first issue. Maybe just update here to be:

        "agate>=1.7.0,<1.10",

If you change the upper bound, then the CI tests will run automatically when you open a PR.

@dbeatty10 dbeatty10 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Apr 15, 2024
@dbeatty10 dbeatty10 removed their assignment Apr 15, 2024
@mjkanji
Copy link
Contributor Author

mjkanji commented Apr 24, 2024

Hi @dbeatty10, thank you for your reply and the input on what's needed to make the change. Please see #9948, which should resolve this. However, it seems that the CI checks were not run because they require a maintainer's approval first. If you could take a look at the PR, that'd be much appreciated!

@dbeatty10 dbeatty10 added the dependencies Changes to the version of dbt dependencies label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants