Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache bust the json files #10

Closed
drewbanin opened this issue Dec 7, 2018 · 1 comment · Fixed by #14
Closed

cache bust the json files #10

drewbanin opened this issue Dec 7, 2018 · 1 comment · Fixed by #14

Comments

@drewbanin
Copy link
Contributor

These files should never be cached.

Use a url parameter with the current timestamp when fetching the json files to bust the browser cache.
@drewbanin drewbanin mentioned this issue Feb 13, 2019
Merged
amirbtb referenced this issue in brocolidata/dbt-docs Jan 3, 2023
@amirbtb
Merge pull request #10 from brocolidata/feature/translated_data_catalog
bfde8d6 
add debug in CD 4
@sfc-gh-afedorov
Copy link

Why shouldn't they be cached? Seems if they haven't changed since the last time the page was loaded, getting a 304 Not Modified can save us ~30MB, which is a chunk of load time for a lot of folks on a globally distributed team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cache bust, error on failure to download json files dbt-labs/dbt-docs
2 participants
@drewbanin @sfc-gh-afedorov