Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Add integration tests #12

Closed
jtcohen6 opened this issue Feb 26, 2020 · 2 comments
Closed

Add integration tests #12

jtcohen6 opened this issue Feb 26, 2020 · 2 comments

Comments

@jtcohen6
Copy link
Contributor

We don't currently have any integration tests. Until we do, we need to rely on manual end-to-end testing and the (currently small) community of Presto users to validate proposed changes.

There's much more to think about here:

  • How can we set up a reasonable testing environment for Presto? Running everything via the memory catalog is a fine way to check syntax, but it's probably not a good representation of how people run Presto in the wild.
  • The dbt-spark plugin uses a modified version of https://github.com/fishtown-analytics/dbt-integration-tests. The dbt-presto plugin does not support incremental models. How might dbt-integration-tests (or dbt-core) define a matrix of available features and associated tests, such that each adapter can declare which ones it does (or doesn't) support?
@jtcohen6
Copy link
Contributor Author

There are two dbt-core considerations relevant to this issue:

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Apr 2, 2020

Closing this, now that we have some integration tests running in CI. The better answer requires significant work in dbt-core, which should stem from the issue linked above.

@jtcohen6 jtcohen6 closed this as completed Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant