Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1070] [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale #686

Closed
2 tasks done
Tracked by #7571
dbeatty10 opened this issue Dec 11, 2023 · 4 comments
Closed
2 tasks done
Tracked by #7571
Assignees
Labels
bug Something isn't working regression support

Comments

@dbeatty10
Copy link
Contributor

Is this a new bug in dbt-redshift?

  • I believe this is a new bug in dbt-redshift
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Look at https://github.com/dbt-labs/dbt-redshift/pkgs/container/dbt-redshift/versions?filters%5Bversion_type%5D=tagged

1.3.0 is tagged as latest:

image

Expected Behavior

1.6.4 is tagged as latest and 1.6.latest:

image

And the rest of the 1.x minor versions have 1.x.latest tags as well.

Steps To Reproduce

See current behavior above.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-redshift:

Additional Context

No response

@dbeatty10 dbeatty10 added bug Something isn't working triage labels Dec 11, 2023
@github-actions github-actions bot changed the title [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale [ADAP-1070] [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale Dec 11, 2023
@dbeatty10 dbeatty10 removed the triage label Dec 11, 2023
@mikealfare
Copy link
Contributor

@dbeatty10 I noticed this as well a month or so ago. Apparently this isn't something we can fix, nor does it get used. I agree it's a wart, but I'm closing this as "can't do".

@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@dbeatty10
Copy link
Contributor Author

dbt-labs/dbt-core#9495 fixes the underlying issue (thank you @mikealfare !), and this particular issue will be resolved for each 1.x version of this adapter upon its next patch release.

We are choosing not to address any un-supported versions at this time, so <=1.4.x will not be updated.

Here are the most recent ones for the supported versions of dbt-redshift in PyPI:

  • 1.7.2
  • 1.6.5
  • 1.5.11

So this will be completely resolved for >=1.5.x when each of the following are released (but only if each is released prior to falling out of support):

  • 1.7.3
  • 1.6.6
  • 1.5.12

@dbeatty10 dbeatty10 reopened this Jan 31, 2024
@dbeatty10 dbeatty10 reopened this Feb 8, 2024
@mikealfare
Copy link
Contributor

We released 1.5, 1.6, and 1.7 last Thursday and they all showed up with the proper labels under Packages. Closing as complete.

@dbeatty10
Copy link
Contributor Author

Screenshot of latest and 1.7.latest, etc.:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression support
Projects
None yet
Development

No branches or pull requests

4 participants