Add SemanticManifestValidator
rule for checking WhereFilter.call_parameter_sets
of Metric
filters
#120
Labels
SemanticManifestValidator
rule for checking WhereFilter.call_parameter_sets
of Metric
filters
#120
Context
Metric
s can have manyWhereFilter
s associated with them. Specifically:Metric.filter
Metric.type_params.measure.filter
Metric.type_params.denominator.filter
Metric.type_params.numerator.filter
Metric.type_params.input_metrics[x].filter
That's quite a few filters. Additionally the
where_sql_template
of aWhereFilter
is a highly structured. Technically with Addcall_parameter_sets
to theWhereFilter
Protocol #110call_parameter_sets
guarantees the structure of aWhereFilter
swhere_sql_template
, but this only happens ifcall_parameter_sets
is actually called. The best way to pseudo guarantee this happens is to add a SemanticManifestValidationRule to the default rules of the SemanticManifestValidator. It's only a pseudo guarantee because from DSI's perspective, it's not guaranteed that aSemanticManifest
has been run through theSemanticManifestValidator
, however that is best practice and what people should do.Acceptance Criteria
THERE EXISTS a SemanticManifestValidationRule
THAT checks
call_parameter_sets
of all filters of all metrics on a SemanticManifestAND the new rule is added to the default rules of the SemanticManifestValidator
The text was updated successfully, but these errors were encountered: