Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import override from typing_extensions~=4.0 #193

Closed
2 tasks done
Fatal1ty opened this issue Oct 26, 2023 · 0 comments · Fixed by #194
Closed
2 tasks done

Can't import override from typing_extensions~=4.0 #193

Fatal1ty opened this issue Oct 26, 2023 · 0 comments · Fixed by #194
Labels
bug Something isn't working

Comments

@Fatal1ty
Copy link
Contributor

Is this a new bug in dbt-semantic-interfaces?

  • I believe this is a new bug in dbt-semantic-interfaces
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

This package currently depends on typing-extensions~=4.0:

"typing-extensions~=4.0",

But here it uses override function which was introduced in typing-extensions 4.4.0:

Since dbt-semantic-interfaces is a direct dependency for dbt-core, it causes ImportError when someone installs dbt-core with typing-extensions>=4.0,<4.4.0:

The solution is to stick to typing-extensions>=4.4.0 or typing-extensions~=4.4. I would prefer the first one because newer versions are getting bugs fixed and new features backported.

Expected Behavior

No ImportError raised.

Steps To Reproduce

  1. pip install dbt-semantic-interfaces
  2. pip install "typing-extensions>=4.0,<4.4.0"
  3. from dbt_semantic_interfaces.transformations import names

Relevant log output

No response

Environment

- OS: Any
- Python: Any
- dbt-semantic-interfaces: 0.3.0

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant