You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the SemanticManifestValidator (currently named ModelValidator) expects a UserConfiguredModel which is a concrete object. Initially we thought we should move to it expecting SemanticManifest protocol. However, in dbt-core we'll be writing nodes which extend the protocol definition. If we want to be able to write validation rules that can operate on the extensions and guarantee type safety, then we need to take it a step further. Thus the SemanticManifestValidator should instead operate on a generic bound by the SemanticManifest protocol.
QMalcolm
changed the title
Update SemanticManifestValidator to expect SemanticManifest Protocol
Update SemanticManifestValidator to expect a generic bound by the SemanticManifest Protocol
Apr 27, 2023
Currently the
SemanticManifestValidator
(currently namedModelValidator
) expects aUserConfiguredModel
which is a concrete object. Initially we thought we should move to it expectingSemanticManifest
protocol. However, in dbt-core we'll be writing nodes which extend the protocol definition. If we want to be able to write validation rules that can operate on the extensions and guarantee type safety, then we need to take it a step further. Thus theSemanticManifestValidator
should instead operate on a generic bound by theSemanticManifest
protocol.Something like...
The text was updated successfully, but these errors were encountered: