Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Identifiers to Entities and update object keys to new spec #9

Closed
Tracked by #7
QMalcolm opened this issue Apr 27, 2023 · 1 comment · Fixed by dbt-labs/metricflow#490
Closed
Tracked by #7
Assignees

Comments

@QMalcolm
Copy link
Collaborator

QMalcolm commented Apr 27, 2023

In the new world of dbt-core x MetricFlow Identifiers are becoming Entities. Additionally some of the properties of the object are changing. The resulting object should have the following properties

Property Name Type Description
name str Name of the entity
type enum Type of the entity
description str Description of the entity
role str Role of the entity
entities List[str] List of composite sub-entities
expr str Expression of the entity

The above properties are were pulled from dbt-labs/dbt-core#7456

@callum-mcdata
Copy link
Contributor

We will be removing the entities property, as we decided that we can push that logic down to the underlying dbt model. @WilliamDee I think you mentioned you didn't want that to be part of the great renaming so flagging it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants