Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop create_metric from the Measure Protocol #99

Closed
QMalcolm opened this issue Jun 27, 2023 · 0 comments · Fixed by #100
Closed

Drop create_metric from the Measure Protocol #99

QMalcolm opened this issue Jun 27, 2023 · 0 comments · Fixed by #100
Assignees
@QMalcolm
Labels
Protocol Spec Change

Comments

@QMalcolm
Copy link
Collaborator

The create_metric key on a measure shouldn't be part of the protocol. It's an ergonomics field that is only ever used at parse time, it's never used by MetricFlow. It can be left on the PydanticMeasure implementation, but should be removed from the protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
Protocol Spec Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop create_metric from the Measure protocol dbt-labs/dbt-semantic-interfaces
1 participant
@QMalcolm