Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add authentication for dbt-worker callback url in tasks.py #212

Open
3 tasks done
vladimirdinolov-8451 opened this issue Apr 6, 2023 · 0 comments
Open
3 tasks done

Comments

@vladimirdinolov-8451
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We're looking at using dbt-server at scale and we've noticed that the call to the endpoint we provide doesn't enable us to add authentication. The endpoint we are providing requires a JWT. For example, the dbt_worker callback URL that was introduced in the latest dbt-server PRs doesn't have an option to authenticate requests.

You can find the source code for the callback URL here: https://github.com/dbt-labs/dbt-server/blob/468c4788859f393c3dbdee73edc8f173ca2ac7e8/dbt_worker/tasks.py#L38

We're wondering if there's a way we can add our own authentication, or if dbt has a solution for configuring authentication that hasn't been released yet.

Describe alternatives you've considered

Adding our own authentication.

Who will this benefit?

Any and all consumers of the dbt-server API.

Are you interested in contributing this feature?

Possibly.

Anything else?

See the source code here: https://github.com/dbt-labs/dbt-server/blob/468c4788859f393c3dbdee73edc8f173ca2ac7e8/dbt_worker/tasks.py#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant