Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add functional test to cover new cover new custom config for tests. #1059

Closed
3 tasks done
McKnight-42 opened this issue May 22, 2024 · 0 comments · Fixed by #1070
Closed
3 tasks done

[Feature] add functional test to cover new cover new custom config for tests. #1059

McKnight-42 opened this issue May 22, 2024 · 0 comments · Fixed by #1070
Assignees
Labels
enhancement New feature or request

Comments

@McKnight-42
Copy link
Contributor

McKnight-42 commented May 22, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

After merging prs made off #dbt-labs/dbt-core#10197 and #dbt-labs/dbt-core#10198 we need to add new tests to dbt-snowflake to handle the custom config options now available

suggested config snowflake_warehouse

Describe alternatives you've considered

suggestion from previous pr is to

dbt-labs/dbt-core#10197 is complete: Add to the functional tests in dbt-snowflake here here. A test configured with a snowflake_warehouse that does not exist should fail. Today, it doesn't, because it doesn't actually use this config.

Who will this benefit?

No response

Are you interested in contributing this feature?

yes

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant