Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement tags setting using base adapter method #918

Open
3 tasks done
colin-rogers-dbt opened this issue Feb 28, 2024 · 0 comments · May be fixed by #922
Open
3 tasks done

[Feature] Implement tags setting using base adapter method #918

colin-rogers-dbt opened this issue Feb 28, 2024 · 0 comments · May be fixed by #922
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Feb 28, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Blocked on: dbt-labs/dbt-adapters#115

Once dbt-adapters has a set metadata method then we want to leverage this new method to set query tags for each query.

specifically we want to update this code to set the query tag session parameter with the output of what the get tags method on the metadata client.

Acceptance Criteria:

  • Functional test that establishes if that if the set metadata method has been called a query tag is added to all subsequent queries

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

Possible prior art: https://hub.getdbt.com/get-select/dbt_snowflake_query_tags/latest/

@colin-rogers-dbt colin-rogers-dbt added enhancement New feature or request triage labels Feb 28, 2024
@colin-rogers-dbt colin-rogers-dbt linked a pull request Mar 4, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant