Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP 619][Bug] Unable to materialize table in anything else than delta #803

Closed
2 tasks done
irsath opened this issue Jun 12, 2023 · 2 comments · Fixed by #955
Closed
2 tasks done

[ADAP 619][Bug] Unable to materialize table in anything else than delta #803

irsath opened this issue Jun 12, 2023 · 2 comments · Fixed by #955
Labels
bug Something isn't working Stale

Comments

@irsath
Copy link

irsath commented Jun 12, 2023

Is this a new bug in dbt-spark?

  • I believe this is a new bug in dbt-spark
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The file_format config is not taken into account.
Table materialization is hard coded to be in delta.

df.write.mode("overwrite").format("delta").option("overwriteSchema", "true").saveAsTable("{{ target_relation }}")

My use case is to have AWS Glue as my global metastore.
I have my databricks clusters linked to my glue metastore and I can successfully read / write tables in it.
Unfortunately I'm not able to write anything else than delta table (as it is hardcoded)

Expected Behavior

The table is materialized in the format specified in the file_format config.

Steps To Reproduce

Execute this model:

from pyspark.sql import SparkSession

def model(dbt, session: SparkSession):
    dbt.config(
        file_format = "iceberg"
    )
    df =  .....my spark df....
    return df

Relevant log output

No response

Environment

- OS: Mac Os
- Python: Python 3.10.3
- dbt-core: 1.5.1
- dbt-spark: 1.5.0

Additional Context

No response

@irsath irsath added bug Something isn't working triage labels Jun 12, 2023
@github-actions github-actions bot changed the title [Bug] Unable to materialize a table in iceberg [ADAP-619] [Bug] Unable to materialize a table in iceberg Jun 12, 2023
@irsath irsath changed the title [ADAP-619] [Bug] Unable to materialize a table in iceberg [Bug] Unable to materialize table in anything else than delta Jun 12, 2023
@irsath irsath changed the title [Bug] Unable to materialize table in anything else than delta [ADAP 619][Bug] Unable to materialize table in anything else than delta Jun 12, 2023
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 10, 2023
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
@dbeatty10 dbeatty10 removed the triage label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
2 participants