Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-790] [Bug] tblproperties macro not used when creating table neccessary for iceberg tables #865

Closed
2 tasks done
etheleon opened this issue Aug 9, 2023 · 2 comments · Fixed by #848
Closed
2 tasks done

[ADAP-790] [Bug] tblproperties macro not used when creating table neccessary for iceberg tables #865

etheleon opened this issue Aug 9, 2023 · 2 comments · Fixed by #848
Labels
bug Something isn't working

Comments

@etheleon
Copy link
Contributor

etheleon commented Aug 9, 2023

Is this a new bug in dbt-spark?

  • I believe this is a new bug in dbt-spark
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

tblproperties macro is declared but not used

Expected Behavior

include in adaptors.sql so it'll be rendered when creating table

Steps To Reproduce

  1. include tblproperties in model config
  2. dbt run
  3. table created without tblproperties

Relevant log output

No response

Environment

- OS: Ubuntu 20.04
- Python: 3.9
- dbt-core: 
- dbt-spark: 1.5.0

Additional Context

No response
@etheleon etheleon added bug Something isn't working triage labels Aug 9, 2023
@github-actions github-actions bot changed the title [Bug] tblproperties macro not used when creating table neccessary for iceberg tables [ADAP-790] [Bug] tblproperties macro not used when creating table neccessary for iceberg tables Aug 9, 2023
@etheleon
Copy link
Contributor Author

etheleon commented Aug 9, 2023

require automated test to test if this adds tblproperties to the create table statement

@dbeatty10 dbeatty10 mentioned this issue Aug 10, 2023
Merged
2 tasks
@dbeatty10
Copy link
Contributor

Resolved in #848

@dbeatty10 dbeatty10 removed the triage label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update adaptors.sql to use tblproperties macro etheleon/dbt-spark
2 participants
@etheleon @dbeatty10