Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'+' config prefix handling whitespace #3526

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

jmriego
Copy link
Contributor

@jmriego jmriego commented Jul 1, 2021

resolves #3494

Description

There is not really supported to add a whitespace after the plus sign in the configuration yml but the error is not intuitive. There was a fix for the eager rendering of macros and this extends this fix for when there's a space between the plus sign and the key (eg. + post-hook)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jmriego jmriego temporarily deployed to Postgres July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 12:39 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 12:39 Inactive
@cla-bot cla-bot bot added the cla:yes label Jul 1, 2021
@jmriego jmriego force-pushed the jmriego_pluswhitespace branch 2 times, most recently from ef8fd93 to 3e71443 Compare July 1, 2021 12:49
@jmriego jmriego temporarily deployed to Postgres July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 12:54 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Redshift July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Postgres July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 1, 2021 14:09 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 09:14 Inactive
@jmriego jmriego temporarily deployed to Redshift July 2, 2021 09:14 Inactive
@jmriego jmriego temporarily deployed to Redshift July 2, 2021 09:14 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Redshift July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Postgres July 2, 2021 09:48 Inactive
@jmriego jmriego temporarily deployed to Postgres July 2, 2021 11:53 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 11:53 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 11:53 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 11:53 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 11:53 Inactive
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one @jmriego!

It looks like the Redshift tests failed for an unrelated reason. I'll get that sorted, but in the meantime this is good to go.

@jmriego jmriego temporarily deployed to Postgres July 2, 2021 16:01 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 16:01 Inactive
@jmriego jmriego temporarily deployed to Bigquery July 2, 2021 16:01 Inactive
@jmriego jmriego temporarily deployed to Redshift July 2, 2021 16:02 Inactive
@jmriego jmriego temporarily deployed to Redshift July 2, 2021 16:02 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 16:02 Inactive
@jmriego jmriego temporarily deployed to Snowflake July 2, 2021 16:02 Inactive
@jtcohen6 jtcohen6 merged commit e10d1b0 into dbt-labs:develop Jul 2, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* '+' config prefix handling whitespace

* rerun ci

automatic commit by git-black, original commits:
  37b03ef
  e10d1b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'+' config prefix should handle whitespace
2 participants