-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'+' config prefix handling whitespace #3526
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
|
1a19e27
to
3169b67
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
|
3169b67
to
3b42418
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jose Valenzuela.
|
3b42418
to
2ec9ba0
Compare
ef8fd93
to
3e71443
Compare
b8bae62
to
f29ff5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one @jmriego!
It looks like the Redshift tests failed for an unrelated reason. I'll get that sorted, but in the meantime this is good to go.
resolves #3494
Description
There is not really supported to add a whitespace after the plus sign in the configuration yml but the error is not intuitive. There was a fix for the eager rendering of macros and this extends this fix for when there's a space between the plus sign and the key (eg.
+ post-hook
)Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.