Use old_relation for renaming in default materializations #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nage changes from view to table and reverse
|
I checked locally and the only failed test is test/integration/004_simple_snapshot_test/test_simple_snapshot.py, which I doubt is influenced by my changes on table and view materializations. |
jtcohen6
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
Thanks for this, @danielefrigo! You're right, the failing test was something flakey/unrelated.
Two tiny changes to the Changelog, then this is good to go.
|
@danielefrigo When you get a chance, could you resolve conflicts / update the changelog? Then this is good to go! |
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
|
sorry for the delay, I've been on vacation with no chance to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2161
Description
change renamed relation to make sure dbt generates the right alter ... rename statement is the materilization type has changed from previous model run
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.