Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret scrubbing for env variables #3617

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Secret scrubbing for env variables #3617

merged 5 commits into from
Jul 27, 2021

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Jul 23, 2021 •
edited

resolves #3440

Description

This change allows users to prefix their environment variables with DBT_ENV_SECRET_ which we will then treat as secrets and scrub them from the logs and console output.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 23, 2021
@leahwicz leahwicz temporarily deployed to Bigquery July 23, 2021 20:30 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery July 23, 2021 20:30 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 23, 2021 20:30 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 23, 2021 20:30 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 23, 2021 20:31 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 23, 2021 20:31 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery July 23, 2021 20:37 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery July 23, 2021 20:37 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 23, 2021 20:37 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 23, 2021 20:37 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 23, 2021 20:37 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 23, 2021 20:37 Inactive
jtcohen6
jtcohen6 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work adding the test.

anyone have a reason to prefer something other than *****?

@leahwicz
Copy link
Contributor Author

anyone have a reason to prefer something other than *****?

I know this is industry standard for CI/CD systems so it would be easy to keep aligned with that

@leahwicz leahwicz marked this pull request as ready for review July 26, 2021 22:49
@leahwicz leahwicz temporarily deployed to Postgres July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Redshift July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Bigquery July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 26, 2021 23:01 Inactive
@leahwicz leahwicz temporarily deployed to Snowflake July 26, 2021 23:01 Inactive
@leahwicz leahwicz merged commit 634bc41 into develop Jul 27, 2021
@leahwicz leahwicz deleted the feature/scrub-secrets branch July 27, 2021 20:06
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@leahwicz @iknox-fa
Secret scrubbing for env variables (#3617)
d5c8df4 
Co-authored-by: Jeremy Cohen <jeremy@fishtownanalytics.com>

automatic commit by git-black, original commits:
  634bc41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@gshank gshank Awaiting requested review from gshank

@kwigley kwigley Awaiting requested review from kwigley

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrub environment variables in target + logs
2 participants
@leahwicz @jtcohen6