Add build RPC method #3674
Merged
Add build RPC method #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
reviewed
Aug 3, 2021
kwigley
approved these changes
Aug 10, 2021
jtcohen6
force-pushed
the
feature/rpc-build-method
branch
from
6b5ac63
to
f625198
Compare
jtcohen6
added a commit
that referenced
this pull request
Aug 10, 2021
* Add build RPC method * Add rpc test, some required flags * Fix flake8 * PR feedback * Update changelog [skip ci] * Do not skip CI when rebasing
jtcohen6
added a commit
that referenced
this pull request
Aug 10, 2021
leahwicz
pushed a commit
that referenced
this pull request
Aug 19, 2021
TeddyCr
pushed a commit
to TeddyCr/dbt
that referenced
this pull request
Sep 9, 2021
* Add build RPC method * Add rpc test, some required flags * Fix flake8 * PR feedback * Update changelog [skip ci] * Do not skip CI when rebasing
kwigley
pushed a commit
that referenced
this pull request
Sep 17, 2021
kwigley
pushed a commit
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3595
dbt buildat Staging next week, so we need to get this in for v0.21.0-b2 and cut that first thing next weekbuildRPC method in order for it to be supported bycli_argsmethod (not something I understand well!)--threadsfor the RPC test to work. I went ahead and added some flags that were easy additions (--full-refresh,--threads,--no-version-check,--defer) but I have not done the exhaustive checking that dbt build: Parity for flags #3596 requires. These are indeed very messy—and I think we'll want to modularize test, seed, snapshot subparser arguments to make them easy additions forbuild.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.